Prudhvi Yarlagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32546 )
Change subject: qcom: Add i2c driver ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c File src/soc/qualcomm/qcs405/blsp.c:
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c@45 PS5, Line 45: clock_configure_i2c(19200000); Hi Patrick, Please let us know if the clock_configure_i2c API should take BLSP_QUP instance also as a parameter?
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c@56 PS5, Line 56: 1
BLSP_ID_ERROR, but what's the point of bailing out _here_ (after enabling i2c halfway)?
Hi Patrick, Please let me know if my understanding to resolve this comment is correct. We need to check the BLSP_QUP_ID at the beginning of this API and return BLSP_ID_ERROR from there instead of checking the id after enabling the clocks.