Attention is currently required from: Furquan Shaikh, Justin TerAvest, Sumeet R Pawnikar, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50127 )
Change subject: drivers/intel/dptf: Add OEM variables support
......................................................................
Patch Set 1:
(3 comments)
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/50127/comment/6b676b82_b7dfab14
PS1, Line 129: DPTF_DEVICE_HID_EISAID
If this is the correct _HID, then I think you'll also need a `_UID` of 0 for the DPTF device itself, and a `_UID` here of 1 since they share this _HID.
https://review.coreboot.org/c/coreboot/+/50127/comment/779e3871_6fc55a3a
PS1, Line 128: if (CONFIG(DPTF_USE_EISA_HID))
: acpigen_emit_eisaid(DPTF_DEVICE_HID_EISAID);
If `DPTF_USE_EISA_HID` is not defined, then there will be an invalid `_HID` object here. If it's only supported by newer DPTF implementations, then it'll have to be the EISA type.
https://review.coreboot.org/c/coreboot/+/50127/comment/d8847656_ea152a7f
PS1, Line 248: acpigen_write_package(6);
: acpigen_pop_len(); /* Scope */
This is just an empty package
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Gerrit-Change-Number: 50127
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Todd Broch
tbroch@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 20:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment