Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40474 )
Change subject: device: Add a helper to find device behind a PCI-to-PCI bridge device ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40474/1/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/40474/1/src/device/device_const.c@2... PS1, Line 228: bus
Need to check bus is not NULL. I don't see any checks in the called functions.
Done
https://review.coreboot.org/c/coreboot/+/40474/4/src/device/device_const.c File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/40474/4/src/device/device_const.c@2... PS4, Line 230: bridge->path.type != DEVICE_PATH_PCI
Yes, from the top of my head IEE1394 to PCI bridges. Ok, one could model […]
Done
https://review.coreboot.org/c/coreboot/+/40474/4/src/device/device_const.c@2... PS4, Line 233: link_list
Okay. I have changed to pcidev_path_behind_pci2pci_bridge(). […]
Done