Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers.
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35040/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35040/5//COMMIT_MSG@9
PS5, Line 9: Currently, we don't have UPDs to set emmc settings per mainboard on CML.
So, do you plan to get rid of this code once FSP UPDs are added?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c72b9851f41585ec099d8ae83a721af87ed383
Gerrit-Change-Number: 35040
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Aug 2019 19:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment