Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47151 )
Change subject: drivers/intel/gma: Add Kconfig option for vbt data size ......................................................................
Patch Set 2:
(3 comments)
I wonder why we don't use the heap (malloc()) instead. We wouldn't need additional (Kconfig) knowledge that way.
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/Kconf... PS2, Line 102: config VBT_DATA_SIZE Please move this somewhere above the `GFX_GMA_*` options.
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/Kconf... PS2, Line 103: int We usually use `hex` and absolute values for sizes, alternatively you can mention the unit in the name, e.g. VBT_DATA_SIZE_KB.
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/opreg... File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/opreg... PS2, Line 22: 9 Please mention in the commit message that this was changed recently. Without knowing that, it looks like you decrease the size for everything but Tiger Lake.