Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42522 )
Change subject: soc/amd/common: Drop ACPIMMIO GPIO bank separation ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42522/5/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42522/5/src/soc/amd/common/block/gp... PS5, Line 139: gpio_set(gpio_num, value);
Good question. […]
I left a reminder in CB:42521 (apu2: Switch to proper GPIO API) to address this.
https://review.coreboot.org/c/coreboot/+/42522/6/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42522/6/src/soc/amd/common/block/gp... PS6, Line 98: __
You are not polluting the global namespace, just this compilation unit. […]
Let's call this avoiding the crowded global gpio_ namespace then.