Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38047 )
Change subject: mb/**/devicetree.cb: Remove comments with lies
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Should the lies be corrected using general description without 'enable' or 'disable'?
E.g. replace 'Enable Deep Sx states' by 'Deep Sx states'.
would be my preference as well
IMHO, it would be somewhat redundant, as the register names already give away what is being configured.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebc4e8c9eb0f44f84acf532ad12a5d064075a102
Gerrit-Change-Number: 38047
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 02 Jan 2020 13:54:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment