Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40616 )
Change subject: mb/google/volteer: Include TCSS power management ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
> Patch Set 1: > > Can this go in southbridge.asl directly so it doesn't need to be added by each mainboard?
It might get confusion since tcss is not part of southbridge.
Tcss is located on northbridge, not PCH. It seems meaningful to include tcss inside northbridge.asl. Is it ok?
northbridge.asl is fine to me.
Sorry, I take it back as northbridge.asl is at src/soc/intel/common/block/acpi. It appears not a proper to include tcss.asl there.
It could be good there since new SOCs will also have TCSS.
Perhaps we need a Kconfig option to enable TCSS in an SOC? There might be more code coming here with all the ACPI generation.
Kconfig can be updated by adding SOC_INTEL_TIGERLAKE_TCSS. But Northbridge.asl is at common/block/acpi and the platform tcss (like tigerlake) is at soc/tigerlake/acpi/tcss.asl. It seems contradiction to the common code principal if simply including platform tcss into northbridge.asl like #if CONFIG(SOC_INTEL_TIGERLAKE_TCSS) #include <soc/intel/tigerlake/acpi/tcss.asl #endif
I guess this is fine in the mainboards for now.
Should there be common TCSS code? i.e. will this TCSS code will be re-usd in future SOCs? We need to start planning now to avoid having to copy this around.