Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge
......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
Patch Set 1:
maybe add a sentence what me_cleaner does? from the text it isn't obvious what "cleaning" the me image does, so i'd add that this will remove as much code as it can from the me image
I'd also add that the ME errors when said code is removed, which is an abnormal state.
Done
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand...
File Documentation/northbridge/intel/sandybridge/me_cleaner.md:
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand...
PS1, Line 4: recommomended
recommended
Done
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand...
PS1, Line 12:
Please remove the blank line at the end of the file.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32889
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I364f3ed49341523c781eb2f3b41e866f33632a7e
Gerrit-Change-Number: 32889
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicola Corna
nicola@corna.info
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 May 2019 14:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment