Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/73612?usp=email )
Change subject: device/pci_rom: rework PCI ID remapping in pci_rom_probe
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
a temporary workaround on the coreboot side to deal with unexpected/broken external configs that ove […]
ouch, the x230 mainboard Kconfig is overriding the SoC default to a non-working value. i guess i only tested libgfxinit on the x230 then and only made sure that the SoC defaults are correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73612?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7da78c69dd702280a78996a5823972516e0319b
Gerrit-Change-Number: 73612
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 21 May 2024 16:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de