Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38383 )
Change subject: intel/i440bx: Resolve long standing raminit TODOs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38383/2/src/northbridge/intel/i440b...
File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/c/coreboot/+/38383/2/src/northbridge/intel/i440b...
PS2, Line 361: // TODO: Only do this later?
Agreed this should be dropped as it just mirrors power on defaults. […]
I'd do it on this change. It's at the top of the patch train, so it's easy to remove the comments on lines 361 and 362. I would change the comment on line 360:
Enable normal refresh, but not yet. Done after raminit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62e8b2531f0f297ffb7db440db89ffa65771b7d5
Gerrit-Change-Number: 38383
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jan 2020 21:24:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment