Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39942 )
Change subject: soc/intel/baytrail: add ACPI backlight support
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39942/2/src/soc/intel/baytrail/gfx....
File src/soc/intel/baytrail/gfx.c:
https://review.coreboot.org/c/coreboot/+/39942/2/src/soc/intel/baytrail/gfx....
PS2, Line 400: device
Everyone else seems to use "dev"
Done
https://review.coreboot.org/c/coreboot/+/39942/2/src/soc/intel/baytrail/gfx....
PS2, Line 402: const struct soc_intel_baytrail_config *chip = device->chip_info;
Will this ever dereference a null pointer?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7fc45bda3aaf89306bedb579fb1e9f8ce07926
Gerrit-Change-Number: 39942
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 14:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment