Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: add support for System76 EC ......................................................................
Patch Set 14:
Patch Set 14:
(1 comment)
Ideally, this would be three patches: one that adds the EC code, one that hooks it up to the console and one that hooks it up to the mainboard.
It was two patches before. Since the ec/system76/ec/acpi directory was mostly moves from the mainboard/system76/lemp9/acpi directory, it was redone as one patch. I can move the console stuff out into a separate patch.
About the console output, where does it go? If it ends up on a UART for instance, it would be better to use the existing functions instead of adding yet another console interface.
The console interface as defined in system76_ec.c will create line-buffered output that is sent to the EC to be multiplexed to any enabled EC console outputs.
An EC running System76 EC may store this in a memory ringbuffer, send it to a parallel port debugger, an I2C debugger, or a UART, depending on the EC's firmware configuration.
It is very different from the other console methods in how it works that it does not make sense to combine it with another console method, in my opinion.