Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46687 )
Change subject: mb/google/asurada: Implement enable_requlator and regulator_is_enabled ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 104: regulator id? It's fine if you wan to print regulator instead of id.
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 118: regulator id?
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 122: = 0 No need for initialization.
https://review.coreboot.org/c/coreboot/+/46687/4/src/mainboard/google/asurad... PS4, Line 126: regulator id?