Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38387
to look at the new patch set (#2).
Change subject: soc/intel/{apl,cnl,icl,skl,tgl}: Update SA bit fields as per EDS ......................................................................
soc/intel/{apl,cnl,icl,skl,tgl}: Update SA bit fields as per EDS
This patch updates system agent related registers bit definitions as per EDS.
For an example: As per EDS MCHBAR register base is between bit 16-38 but coreboot programming was not align with EDS previously.
Also provide provision to program 64bit values as per SA EDS definitions
TEST=Dump MCHBAR in coreboot and ASL shows same 32 bit value.
Change-Id: I37340408fe89c94ce81953c751c8d7e22bc81a42 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/systemagent.c M src/soc/intel/cannonlake/include/soc/systemagent.h M src/soc/intel/cannonlake/romstage/systemagent.c M src/soc/intel/cannonlake/systemagent.c M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/common/block/include/intelblocks/systemagent.h M src/soc/intel/common/block/systemagent/systemagent_early.c M src/soc/intel/icelake/romstage/systemagent.c M src/soc/intel/icelake/systemagent.c M src/soc/intel/skylake/acpi/systemagent.asl M src/soc/intel/skylake/include/soc/systemagent.h M src/soc/intel/skylake/romstage/systemagent.c M src/soc/intel/skylake/systemagent.c M src/soc/intel/tigerlake/romstage/systemagent.c M src/soc/intel/tigerlake/systemagent.c 16 files changed, 90 insertions(+), 76 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/38387/2