Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36627 )
Change subject: soc/intel/icelake: Move early pch initialization from bootblock to romstage ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36627/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36627/2//COMMIT_MSG@10 PS2, Line 10: to romstage/pch.c.
i guess the idea is to do limited programming in bootblock and move the not that urgent bootblock pr […]
We had a similar topic on IRC and the question was what does the bootblock need to initialize? As there's no checklist, the code is usually just copied from earlier generations. While it might be SoC/mainboard specific, having a checklist seems a good idea. I'll create a change for that.
https://review.coreboot.org/c/coreboot/+/36627/4/src/soc/intel/icelake/romst... File src/soc/intel/icelake/romstage/pch.c:
https://review.coreboot.org/c/coreboot/+/36627/4/src/soc/intel/icelake/romst... PS4, Line 65: TCO When should the TCO watchdog be disabled? Will there be a platform reset if verstage takes too many TCO cycles measuring the flash regions?