Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46259 )
Change subject: intel/common/pmc: Add functions for IPC mailbox in ACPI ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46259/11/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmc_ipc.c:
https://review.coreboot.org/c/coreboot/+/46259/11/src/soc/intel/common/block... PS11, Line 127: /* Package with return value and read buffer. */ : acpigen_write_name("RVAL"); : acpigen_write_package(5); : for (i = 0; i < 5; ++i) : acpigen_write_integer(0); : acpigen_pop_len(); :
suggestion: IASL always suggests not creating named objects inside of a method (i'm guessing it's a […]
Done. With the more complicated return package this might need a separate mutex if there were multiple devices trying to read (and process the return data). Currently the return is just ignored by the rtd3 driver so it doesn't really matter since the method itself is serialized. I guess I could make it take the package as an input, but that just complicates the caller...