1 May
2020
1 May
'20
12:29 p.m.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40741 )
Change subject: sb/intel/i82801gx: Fix 16-bit read/write PCI_COMMAND register ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40741/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/usb_ehci.c:
https://review.coreboot.org/c/coreboot/+/40741/2/src/southbridge/intel/i8280... PS2, Line 25: pci_write_config16(dev, PCI_COMMAND, reg16);
why not pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER | PCI_COMMAND_SERR)?
Maybe as a follow-up?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40741
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11b8743234cb1292db8c930edecf8fb5c47d63fd
Gerrit-Change-Number: 40741
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Fri, 01 May 2020 10:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Gerrit-MessageType: comment