Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46273 )
Change subject: soc/intel/cnl: lock AES-NI feature if selected
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46273/6/src/soc/intel/cannonlake/Kc...
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/46273/6/src/soc/intel/cannonlake/Kc...
PS6, Line 81: select CPU_INTEL_COMMON_HYPERTHREADING
What if we would remove the whole Kconfig option and act as if it was set to `y`?
I have left CPU_INTEL_COMMON as condition but can drop that, too, if I should
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79495bfbd3ebf3b712ce9ecf2040cecfd954178d
Gerrit-Change-Number: 46273
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 20:23:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment