HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44370 )
Change subject: {sb/intel/*/azalia.c,device/azalia_device.c}: Reduce differences ......................................................................
Patch Set 6:
(3 comments)
Thx
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c@... PS6, Line 137: 50
That doesn't match the code. […]
see line #148
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c@... PS6, Line 141: reg32 = read32(base + HDA_ICII_REG); : reg32 |= HDA_ICII_BUSY | HDA_ICII_VALID; : write32(base + HDA_ICII_REG, reg32);
Have you tested this?
this change absolutely nothing
https://review.coreboot.org/c/coreboot/+/44370/6/src/device/azalia_device.c@... PS6, Line 226: // NOTE this will break as soon as the azalia_audio get's a bar above 4G.
Yes, and would be good to fix while we're at it
not related to current patch