[coreboot-gerrit] [L] Change in coreboot[main]: acpi: Move EINJ code to vendorcode/ocp

[Martin L Roth (Code Review)]

Attention is currently required from: Arthur Heymans, Jonathan Zhang, Lance Zhao, Rocky Phagura, Tim Wawrzynczak.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77416?usp=email )

Change subject: acpi: Move EINJ code to vendorcode/ocp
......................................................................

Patch Set 3:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/77416/comment/1b9e784f_e6ddbd8f :
PS3, Line 7: acpi: Move EINJ code to vendorcode/ocp
> So some technical insight. The code in acpi. […]

They *could* stay, but there's no reason to keep them if we're moving everything else out. We wouldn't implement header files for random tables that weren't actually implemented in coreboot, so I'd argue these shouldn't be left in the main ACPI header file.

Unrelated to this patch, I'd actually like to split up the main acpi.h file into the separate tables. It's gotten too large IMO.

File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/77416/comment/acd74d24_821f38b7 :
PS3, Line 78: EINJ
> should we keep this here ?

Yes, that must remain. It's just a value in an enum though, so it doesn't do anything if it's not used.