Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Add ThinkPad R60 iGPU support. ......................................................................
Patch Set 25:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35293/25//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35293/25//COMMIT_MSG@9 PS25, Line 9: It runs without any blobs in firmware please be more descriptive here. What does work and what doesn't. Add TODOs.
https://review.coreboot.org/c/coreboot/+/35293/25/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35293/25/Documentation/mainboard/le... PS25, Line 1: v file needs to be referenced from index.md
https://review.coreboot.org/c/coreboot/+/35293/25/Documentation/mainboard/le... PS25, Line 9: Things working: ##
https://review.coreboot.org/c/coreboot/+/35293/25/Documentation/mainboard/le... PS25, Line 17: Things not working: ##
https://review.coreboot.org/c/coreboot/+/35293/25/src/mainboard/lenovo/r60/m... File src/mainboard/lenovo/r60/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35293/25/src/mainboard/lenovo/r60/m... PS25, Line 58: if (!(inb(DEFAULT_GPIOBASE + 0x0c) & 0x40)) { get_gpio()
https://review.coreboot.org/c/coreboot/+/35293/25/src/mainboard/lenovo/r60/s... File src/mainboard/lenovo/r60/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35293/25/src/mainboard/lenovo/r60/s... PS25, Line 33: printk(BIOS_DEBUG, "initializing SMI\n"); remove pointless function