Attention is currently required from: Felix Singer, Matt Delco, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Subrata Banik, Michael Niewöhner, Kyösti Mälkki, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57886 )
Change subject: acpigen,cpu/intel/common: rework detecting static DWORDs in CPPC table
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
Add a type to the CPPC entry, i.e. (ADDR, DWORD). […]
A simple tagged union is all you need here, e.g.:
```
struct cppc_entry {
enum { ADDR, DWORD } type;
union {
acpi_addr_t addr;
uint32_t dword;
};
};
```
No need to transform it then:
```
if (entry->type == ADDR)
acpigen_write_register_resource(&entry->addr);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib853261b5c0ea87ae2424fed188f2d1872be9a06
Gerrit-Change-Number: 57886
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Matt Delco
delco@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 28 Sep 2021 22:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment