Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )
Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44632/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/eldrid/memory.c:
https://review.coreboot.org/c/coreboot/+/44632/4/src/mainboard/google/voltee...
PS4, Line 8: };
This also indirectly sets ECT to 0, which will not disable early command training. […]
I noticed that Early Command Training can only be enabled for lpddr4, so leaving as 0 makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44632
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c7b30093a8d85bac5aba5b83768af5eb36c4f70
Gerrit-Change-Number: 44632
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Assignee: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 26 Aug 2020 23:35:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment