Attention is currently required from: Julius Werner.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74243?usp=email )
Change subject: arch/x86: Disable walkcbfs_asm code when CONFIG_CBFS_VERIFICATION is set
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
If that isn't possible for QEMU then I'd suggest just disabling CBFS verification for it (via Kconfig dependencies). It's not like anyone really needs verification on an emulation board anyway.
It would be nice to have that in order to easily test the CBFS verification. But I guess we can just use a different QEMU emulation target for that (e.g. ARM or RISC-V). If no one has currently the time or need to actually fix this (no one apparently noticed it for a year), I would also just disable CBFS verification for the boards using `src/cpu/qemu-x86` until someone makes an effort to fix this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74243?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I614a1b05881aa7c1539a7f7f296855ff708db56c
Gerrit-Change-Number: 74243
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 07 Mar 2024 10:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment