Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber, Johnny Lin, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35919 )
Change subject: inteltool: Allow to set cores range for MSRs dump
......................................................................
Patch Set 18:
(1 comment)
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/35919/comment/8faae7a7_787ddc97
PS18, Line 521: <start-end>
Actually, it's […]
I'm not sure, but maybe it should look like this:
--cpu-range [<core> | <start-end>] ?
The fact is that when we use one parameter only:
sudo ./intertool -M --cpu-range 10,
inteltool prints a dump for one core only.
I didn't add a separate option --cpu-core <core>.
But maybe this option is needed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a037cf7ac270d2b51d6e453334c358ff47b4105
Gerrit-Change-Number: 35919
Gerrit-PatchSet: 18
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 27 Jul 2021 10:02:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment