Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )
Change subject: mediatek/mt8183: add dsi driver for mt8183
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/31591/16/src/soc/mediatek/mt8183/ds...
File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/c/coreboot/+/31591/16/src/soc/mediatek/mt8183/ds...
PS16, Line 399: count
we may remove count?
https://review.coreboot.org/c/coreboot/+/31591/16/src/soc/mediatek/mt8183/ds...
PS16, Line 413: break
return;
https://review.coreboot.org/c/coreboot/+/31591/16/src/soc/mediatek/mt8183/ds...
PS16, Line 459: u32 count
8173 init uses the END_OF_TABLE so there's need to count. […]
oh, sorry, 8173 didn't really do table init. but since you've declared END_OF_TABLE, why not use it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31591
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic413f524ca0b36f0b01f723a71fe9745e2710cd2
Gerrit-Change-Number: 31591
Gerrit-PatchSet: 16
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 20 Jul 2019 02:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment