Attention is currently required from: Felix Singer, Shelley Chen, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Aamir Bohra, Patrick Rudolph. Hello Felix Singer, Shelley Chen, build bot (Jenkins), Nico Huber, Patrick Georgi, Furquan Shaikh, Tim Wawrzynczak, Aamir Bohra, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57949
to look at the new patch set (#3).
Change subject: Revert "soc/intel/cannonlake: Allow Audio DSP OSC qualification for low power idle" ......................................................................
Revert "soc/intel/cannonlake: Allow Audio DSP OSC qualification for low power idle"
This reverts commit 4d9d3f164de7002dd38f12dc40f9b260f63d2d9b and commit e65f500a0b90ccbf1a172427b7a61a047571ff02.
Reason for revert:
The commit message does not make clear what the actual problem is or was. The reference to a non-public bug tracker makes it quiet difficult to make any sense of it.
According to the datasheets this means the Audio DSP oscillator is not required to be powered off in order to enter SlpS0/S0ix. However, that bit already defaults to zero and even FSP does not set it. Thus, clearing that bit is not required.
Change-Id: Iff028364fb34f737c3a50809f2df623a0bba7218 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/finalize.c M src/soc/intel/cannonlake/include/soc/pmc.h 4 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/57949/3