Jorge Fernandez has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37551 )
Change subject: amd/hudson: Rename PCI IDs for FCH SATA Controller ......................................................................
Patch Set 6:
(5 comments)
I don't understand. In this commit I'm renaming from PCI_DEVICE_ID_AMD_CZ_SATA to PCI_DEVICE_ID_AMD_CZ_SATA_IDE as the message says. The commit you say to be squashed with defines a new PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_AMD... Isn't it better to have two different commits for different things?
https://review.coreboot.org/c/coreboot/+/37551/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37551/1//COMMIT_MSG@9 PS1, Line 9: The 1022:7904 FCH
This doesn't seem to match what your change is doing.
Done
https://review.coreboot.org/c/coreboot/+/37551/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37551/3//COMMIT_MSG@7 PS3, Line 7: amd/hudson: Add PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver.
Please remove the dot/period at the end of the git commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/37551/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37551/4//COMMIT_MSG@7 PS4, Line 7: Add PCI ID for FCH SATA Controller (AHCI Mode) for AMD driver
Nit: at this point, you're no longer adding, but renaming.
Done
https://review.coreboot.org/c/coreboot/+/37551/4//COMMIT_MSG@10 PS4, Line 10: This new device ID is found in the AMD Bettong board. : Support is added to configure properly the SATA device in initialization.
This text looks a little stale too.
Done
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37551/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_MS 0x7901
Paul, I infer Microsoft. I think I prefer simply ... […]
Done