[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Configure serial debug uart

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31375 )

Change subject: soc/intel/cannonlake: Configure serial debug uart
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/31375/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31375/2//COMMIT_MSG@10 
PS2, Line 10: SerialIoDebugUartNumber UPD use to select UART Number for Debug Purpose
> Can you please add details indicating that this UPD defaults to 2 if not set and hence it needs to b […]

done

https://review.coreboot.org/#/c/31375/2/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/31375/2/src/soc/intel/cannonlake/fsp_params.... 
PS2, Line 166: *
> space before *

done

https://review.coreboot.org/#/c/31375/2/src/soc/intel/cannonlake/fsp_params.... 
PS2, Line 166: *
> space after *

done