Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47036 )
Change subject: sb/intel/lynxpoint/lpc.c: Relocate lock bit write ......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47036/comment/73d46084_940b1974 PS7, Line 9: This lock bit can be set later
Many others that are set early potentially too. Why make an […]
The BS/BWGs suggest doing this register write after other steps are done. Reference code also defers this write to happen in PchInitBeforeBoot instead.
Also, it is currently set in a LPT-LP specific function, and I'd rather move the write elsewhere than duplicate it. This also eases unifying with Broadwell, which does the lock bit write in a dedicated finalisation function after `spi_finalize_ops()`.