Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43061 )
Change subject: soc/intel/tigerlake: Update Tiger Lake SA IDs
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43061/5/src/soc/intel/tigerlake/boo...
File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/43061/5/src/soc/intel/tigerlake/boo...
PS5, Line 35: PCI_DEVICE_ID_INTEL_TGL_ID_U
Would you mind to append this *_4_2 to match with name string. Also, it will be align with below *_2_2
This will give better code readability and quick reference as well.
https://review.coreboot.org/c/coreboot/+/43061/5/src/soc/intel/tigerlake/boo...
PS5, Line 37: PCI_DEVICE_ID_INTEL_TGL_ID_Y
same comment as above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9d9c9ac3bf39582b0da610e6ef912031939c763
Gerrit-Change-Number: 43061
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 06:25:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment