wang qii has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46573 )
Change subject: WIP: soc/mediatek/mt8192: add i2c driver support
......................................................................
Patch Set 7:
(1 comment)
I have merge that two patch to: https://review.coreboot.org/c/coreboot/+/47800
https://review.coreboot.org/c/coreboot/+/46573/4/src/soc/mediatek/mt8192/i2c...
File src/soc/mediatek/mt8192/i2c.c:
https://review.coreboot.org/c/coreboot/+/46573/4/src/soc/mediatek/mt8192/i2c...
PS4, Line 10: struct
What do you mean by "other references"? If this is supposed to be a constant array then we should a […]
src/soc/mediatek/mt8183/i2c.c and src/soc/mediatek/mt8173/i2c.c, if we add
'const' modifier here, that will case build fail. I think it need a code style patch to fix it separately.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8ece265687d37bafe2f0de63459ea0fabab8a11
Gerrit-Change-Number: 46573
Gerrit-PatchSet: 7
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: wang qii
Qii.Wang@mediatek.com
Gerrit-Comment-Date: Thu, 26 Nov 2020 06:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: wang qii
Qii.Wang@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment