Skoll RC has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ......................................................................
Patch Set 41:
(10 comments)
Hi,
Elyes can upload it is not a problem to me. As we are both french speakers, we discuss a lot in private. He helped me a lot to finish this port. If I have something in particular to let him upload, just let me know. I do not have a lot time to work on coreboot port so it's better if someone else can help.
https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/33//COMMIT_MSG@26 PS33, Line 26: - Tianocore payload (CorebootPayload)
Just a black screen without any outputs (no videos, no USB console). […]
Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.md:
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 48: - There is no automatic, OS-independent fan control. : The `coretemp` driver can still be used for : accurate CPU temperature readings.
Your board doesn't have a SuperIO, so it doesn't really have this
Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 51: - me_cleaner breaks LPC bus and attached components!
There is nothing on the LPC, I didn't remove this because there is in fact a problem with reduced ME […]
Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 52: - Tianocore payload. The reason is yet undiscovered.
no! Maybe this is the problem.
Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 66: -
Your board doesn't have a SuperIO, so it doesn't really have this
Done
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.png:
PS36:
This picture is really blurry and very large. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... File Documentation/mainboard/ongy/p8h61-m_pro.md:
https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 13: W25Q32BV
I need to replace with the correct flash chip model
Done
https://review.coreboot.org/c/coreboot/+/40813/35/Documentation/mainboard/on... PS35, Line 51: me_cleaner breaks LPC bus and attached components!
Need to test this as quick as I can. I tried one's to use me_cleaner without success. […]
Done
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 17: default ongy/h61m-s1
default "ongy/h61m-s1"
Done
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/early_init.c:
https://review.coreboot.org/c/coreboot/+/40813/38/src/mainboard/ongy/h61m-s1... PS38, Line 2: : #include <device/pci_ops.h>
not used. Please remove.
Done