Marcello Sylvester Bauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39799 )
Change subject: Documentation: Spell vboot all lowercase ......................................................................
Patch Set 3:
(7 comments)
Patch Set 1:
(7 comments)
Thanks for doing this! Feel free to fix vboot_reference too, which has numerous instances of "Vboot" (=
Personally, I don't know if they should be changed, because they are in the beginning of each sentence. vboot is its own name but looks weird IMHO compared to all the other comments.
https://review.coreboot.org/c/coreboot/+/39799/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39799/1//COMMIT_MSG@9 PS1, Line 9: occurences
occurrences
Done
https://review.coreboot.org/c/coreboot/+/39799/1//COMMIT_MSG@9 PS1, Line 9: lower case
lowercase
Done
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/releases/core... File Documentation/releases/coreboot-4.5-relnotes.md:
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/releases/core... PS1, Line 76: * Google (22 commits) - vboot2 updates and cleanup
Not sure we should change notes from previous releases?
There are also retroactive change in other relnotes (e.g. see git blame coreboot-4.8.1-relnotes.md). Therefore I don't think it's a problem.
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/security/vboo... File Documentation/security/vboot/index.md:
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/security/vboo... PS1, Line 191:
Are these spaces here for a reason? Maybe we can take them out while we're at it. […]
Done
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/security/vboo... PS1, Line 199: access
accesses
Done
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/security/vboo... PS1, Line 199: it's
Could we correct this to "its" while we're at it?
Done
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/security/vboo... File Documentation/security/vboot/list_vboot.md:
https://review.coreboot.org/c/coreboot/+/39799/1/Documentation/security/vboo... PS1, Line 1:
vboot-enabled
Thanks. I noticed that this changes has to be done in vboot_list.sh script, which generates this list.