[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Set controller state to active in GSPI init

[Meera Ravindranath (Code Review)]

Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34449 )

Change subject: soc/intel/common: Set controller state to active in GSPI init
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34449/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/gspi/gspi.c:

https://review.coreboot.org/c/coreboot/+/34449/2/src/soc/intel/common/block/... 
PS2, Line 455: devfn = gspi_soc_bus_to_devfn(dev->bus);
             : 	device = pcidev_path_on_root(devfn);
             : 
             : 	/* Ensure controller is in D0 state */
             : 	lpss_set_power_state(device, STATE_D0);
> Shouldn't this be done after all the initial checks are done i.e. […]

Thank you. Yes, I am considering doing it after the reset i.e line 480. Would that be okay?