[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/rauru: Add panel driver in mainboard

[Yidi Lin (Code Review)]

Attention is currently required from: Bincai Liu, Hung-Te Lin, Jarried Lin.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/google/rauru: Add panel driver in mainboard
......................................................................

Patch Set 11:

(2 comments)

File src/mainboard/google/rauru/panel_oled.c:

https://review.coreboot.org/c/coreboot/+/85951/comment/d69720f6_b65ce11a?usp... :
PS11, Line 19: mdelay(400);
I don't think we need this. We take more than 400ms before jumping to payload. (eDP already takes 200ms)

https://review.coreboot.org/c/coreboot/+/85951/comment/989d7340_00a8df6a?usp... :
PS11, Line 20: 	gpio_output(GPIO_AP_EDP_BKLTEN, 1);
             : 	gpio_output(GPIO_BL_PWM_1V8, 1);
We turn on the backlight in the payload. So we should turn off them here.