Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33740 )
Change subject: Documentation: Update soc/intel/apollolake ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... File Documentation/soc/intel/apollolake/index.md:
PS3: To me, this reads totally confusing now. Wouldn't it be worth to stick to the terms Intel uses? I fear, for anyone who has more Intel than FMAP background, this document is a bummer.
Intel terms:
* IFD entries => "regions" * LBP1/LBP2 => "partitions" * upatch1/IBBP/OBBP/etc. => "sub-partitions" * sub-partitions can be "directories" => e.g. IBBP directory contains IBBL, IBB for instance
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 17: IFWI firmware components What makes them IFWI firmware components? Aren't they simply `firmware compontents`?
https://review.coreboot.org/c/coreboot/+/33740/3/Documentation/soc/intel/apo... PS3, Line 17: * Each LBP has its own copy of IFWI firmware components and OBB Why mention OBB separately? I know most FMD files treat it like that, but that's very confusing alone and not necessary. Would it be better to mention once in a prominent place that IFWI and FMD naming may differ?