Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 12: #ifndef CONFIG_DPTF_CPU_ADDR : CONFIG_DPTF_CPU_ADDR = 0x00040000ul, : #endif
This is the default for DPTF, for all SoCs I've seen except the Core line (APL, etc. […]
Ack
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 76: INT3404
Also will this still work with our open-source DPTF implementation? Is it expecting the old HIDs?
Ack
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 86: INT3403
for tigerlake these EISAID seems to be changed as per https://chromium-review.googlesource. […]
Ack
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 100: INT3403
for tigerlake these EISAID seems to be changed as per https://chromium-review.googlesource. […]
Ack
https://review.coreboot.org/c/coreboot/+/41884/4/src/drivers/intel/dptf/dptf... PS4, Line 101: acpigen_write_name_integer("TMPI", id);
It was included in the previous implementation, and seemed to be only used in the vendor-specific fu […]
Ack