Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37514 )
Change subject: soc/intel/skylake: Add option to control microcode update inclusion
......................................................................
Patch Set 5:
Sorry, I'm late. I'm not very happy about the prompts. "Board can ..."
doesn't sound like a user decision. Also, some prompts are even for
soldered down CPUs. This is nothing a user should be prompted for.
Also, we already had two means to override the default decision:
* `config CPU_MICROCODE_CBFS_EXTERNAL_BINS`, and
* mainboard makefiles can overwrite `cpu_microcode_bins`.
Now, if a board maintainer would choose to do the latter, it would
override the prompted Kconfig settings :-/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa36c2846b2279a2eb2b61e6c97d6c89d0736f55
Gerrit-Change-Number: 37514
Gerrit-PatchSet: 5
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 07 Dec 2019 12:10:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment