Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39366 )
Change subject: lib/spd_bin: Correct LPDDR3 SPD information ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39366/3/src/lib/spd_bin.c File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/39366/3/src/lib/spd_bin.c@33 PS3, Line 33: is_memory_type_ddr4 I think this should be named something like "use_ddr4_params" since the memory type is not really ddr4 but still it is using the params/attributes same as ddr4.
https://review.coreboot.org/c/coreboot/+/39366/3/src/lib/spd_bin.c@36 PS3, Line 36: case SPD_DRAM_DDR3: : case SPD_DRAM_LPDDR3_INTEL: : return false; : /* LPDDR3, LPDDR4 and DDR4 share the same attributes */ : case SPD_DRAM_LPDDR3_JEDEC: : case SPD_DRAM_DDR4: : case SPD_DRAM_LPDDR4: : default: : return true; Just use --
case SPD_DRAM_LPDDR3_JEDEC: case SPD_DRAM_DDR4: case SPD_DRAM_LPDDR4: return true; default: return false;