[coreboot-gerrit] Change in coreboot[master]: soc/apollolake: Make IO decode / enable register configurable

[Andy Pont (Code Review)]

Attention is currently required from: Sean Rhodes, Andrey Petrov, Patrick Rudolph.
Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61195 )

Change subject: soc/apollolake: Make IO decode / enable register configurable
......................................................................

Patch Set 2:

(3 comments)

File src/soc/intel/apollolake/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/61195/comment/74a47110_8669d2cd 
PS2, Line 90: 	const uint16_t lpc_ioe_enable_mask = LPC_IOE_COMA_EN | LPC_IOE_COMB_EN |
This looks ugly!  I think it would be better if it were put into a header file as:

```
#define APL_LPC_IOE_ENABLE_MASK 0x3f0f
```

See below comment as well...

https://review.coreboot.org/c/coreboot/+/61195/comment/b479e177_a279061c 
PS2, Line 96: 	const config_t *config = config_of_soc();
```
const config_t *config = config_of_soc();
const uint16_t io_enables = config->lpc_ioe & APL_LPC_IOE_ENABLE_MASK;

if (io_enables) {
    ...
} else {
    ...
}
```

https://review.coreboot.org/c/coreboot/+/61195/comment/b6378014_7637a766 
PS2, Line 99: 		io_enables = config->lpc_ioe & lpc_ioe_enable_mask;
Shouldn't we actually be doing something with io_enables?  Looks like a call to lpc_set_fixed_io_ranges() or similar is missing.