Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45108 )
Change subject: mb/system76/lemp9: Move USB options into devicetree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45108/2/src/mainboard/system76/lemp...
File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45108/2/src/mainboard/system76/lemp...
PS2, Line 141: # USB3
newline above
I don't want to blow up the devicetree with empty lines. I think these comments are enough to differentiate between general options, usb2 and usb3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45108
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3371bed7c2678fbc3304f53af1413a93462933f5
Gerrit-Change-Number: 45108
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Sep 2020 23:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment