Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: [WIP] sb/intel/bd82x6x: Support ME Software Disable Mode ......................................................................
Patch Set 5:
(3 comments)
I marked it as WIP. Twice. I think it's clear that it's not ready for review.
https://review.coreboot.org/c/coreboot/+/37115/5/src/mainboard/lenovo/x230/c... File src/mainboard/lenovo/x230/cmos.default:
https://review.coreboot.org/c/coreboot/+/37115/5/src/mainboard/lenovo/x230/c... PS5, Line 17: Disable
What does this even mean? Is it disabling the ME by default, or disabling ME disablement (that is, e […]
Second.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 765: mkhi_hmrfpo_enable
Isn't this what you want to do?
No.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 768: mkhi_global_reset
Isn't this your reset() function?
No.