Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34449 )
Change subject: soc/intel/common: Set controller state to active in GSPI init
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34449/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/34449/5/src/soc/intel/common/block/...
PS5, Line 450: uint32_t
Yes, right. […]
Yes, please, I was wrong, the function does return signed int. The reason I asked for change was the devfn would be always unsigned for a valid gspi bus. which would be the case for all ctrl setup call.
May be now also add a check for a error in gspi_soc_to_devfn(if it returns -1) and exit the setup call.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f95059453ca5565a38650b147590ece4d8bf5ed
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 5
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 05:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment