Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40674 )
Change subject: arch/x86/acpi_device: Add a helper function to write PCI device
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/acpi_device.c
File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/40674/2/src/arch/x86/acpi_device.c@...
PS2, Line 952: dev->enabled
Since the device is still present and the kernel re-enumerates anyway, should we write out the node […]
Makes sense. We can use acpi_device_status() to determine that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I932af917d91198876fe8e90af9bb7a2531bd8960
Gerrit-Change-Number: 40674
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 23 Apr 2020 21:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment