Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21073 )
Change subject: soc/amd: Standardize guards on header files ......................................................................
Patch Set 1:
(2 comments)
If you touch this patch again, you could also standardize the #endif /* __NAME_H__ */ . Some have a tab after endif and others a single space. Otherwise, meh.
https://review.coreboot.org/#/c/21073/1/src/soc/amd/common/dimmSpd.h File src/soc/amd/common/dimmSpd.h:
https://review.coreboot.org/#/c/21073/1/src/soc/amd/common/dimmSpd.h@26 PS1, Line 26: #endif I saw you added a comment in another file on an #endif. I don't feel like one is needed here, but thought I'd mention it in case you left it out accidentally.
https://review.coreboot.org/#/c/21073/1/src/soc/amd/stoneyridge/include/soc/... File src/soc/amd/stoneyridge/include/soc/imc.h:
https://review.coreboot.org/#/c/21073/1/src/soc/amd/stoneyridge/include/soc/... PS1, Line 27: #endif Same comment as before regarding the #endif.