Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42905 )
Change subject: mb/google/volteer: Add support for passive USB-C daughterboard ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42905/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42905/1/src/mainboard/google/voltee... PS1, Line 159: device generic 1 on : probe DB_USB USB4_GEN2 : probe DB_USB USB3_ACTIVE : probe DB_USB USB4_GEN3 : probe DB_USB USB3_NO_A : end : end : chip drivers/intel/pmc_mux/con : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU & HSL follow CC : device generic 1 on : probe DB_USB USB3_PASSIVE : end
You would need to get a few device references yes and fix up the values, roughly: […]
I think it is ok for now, it is convenient to have the configuration all visible in the devicetree.
It should be possible to make it so we can set a register to different values based on a probe rather than needing to duplicate devices, but that will take some sconfig changes.