Attention is currently required from: Nico Huber, Nick Vaccaro, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: Add type-c port info to cbmem
......................................................................
Patch Set 20:
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/cbef21eb_c801a918
PS20, Line 47: if (!acpi_is_wakeup_s3())
This check should be the first thing in the function so that you don't need to get cbmem buffer, etc.
```
const struct drivers_intel_pmc_mux_conn_config *config = config_of(dev);
struct type_c_info *info;
struct type_c_port_info *port_info;
size_t count;
/* Comment explaining why we don't need to add anything to CBMEM in this case. */
if (acpi_is_wakeup_s3())
return;
info = conn_get_cbmem_buffer();
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic56a1ad1b617e3af000664147d21165e6ea3a742
Gerrit-Change-Number: 57345
Gerrit-PatchSet: 20
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 04 Oct 2021 18:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment