30 Sep
2020
30 Sep
'20
11:40 p.m.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... PS17, Line 107: y
Isn't storing DRAM part number in the CBI a POR for chromeos devices? If so, why would we not want […]
I can see how opting in might be better/safer than opting out, even if storing name in CBI is standard practice for current devices.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d393efd0fc731daa70d3990e5b69865be99b78b
Gerrit-Change-Number: 45635
Gerrit-PatchSet: 18
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Sep 2020 21:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Nick Vaccaro nvaccaro@google.com
Gerrit-MessageType: comment